Re-establish feature resolver version 1 compatibility #4327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
resolver-v1
branch
7 times, most recently
from
744bd6e to
a317e5b
Compare
This was referenced Dec 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes re-establish feature resolver version 1 compatibility.
Instead of using crate features we use macros defined in
wasm_bindgen::__rt. This was possible because we movedallow_internal_unstablefrom the proc-macro to these new macros.Thanks @taiki-e for proposing and finding this solution.
Fixes #4304.
Replaces #4306.
Reverts #4284.
Reverts #4307.